Ultimate improvement of the library #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Port compile_tzlinks.py to python3, use geonames instead of nominatim * Port other scripts to python3 * Update timezone database * Fix leap year formula * Make zone names char * Reduce C warnings * Make declarations extern * Add leap year test * Unit tests, some refactoring and fixes * Fix and test daylight saving time for US * Test DST on previous UTC day * More tests * Timezone iterator function * Handle no rules case * Add default timezone * More initialization functions * Negate and subtract offset * Add aliased datetime fields * Compile zones * Set tz name pointer from the table * 16-bit year * Apply namespace to types * Apply namespace to macros * Newline at EOF * Export zone count * Offset comparison function * Delete controversial comment * Format abbreviations with %s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported scripts to python3, fixed a lot of bugs, added unit tests, cleaned-up and changed library interface to prevent name collisions. Basically, made this library useful (before the fix even the leap year function had a bug).