Fix cleanup command and add restricted users to cleanup process #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Both commits are fine. Would it be possible that you cover the second commit with functional tests? If you need this change for TYPO3 v13 too, please create an additional PR against branch 13.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue with the cleanup command. The tables for the references cleanup aren't set correctly.
Beside that, for us it's a use-case to cleanup hidden users, as they get an "inactive" group upon registration which is switched after confirmation. So we also want to include hidden users. Should this go into the extension or is this behavior not wanted?