Fix package.json to enable importmap pin#17
Open
swombat wants to merge 1 commit intoevilmartians:mainfrom
Open
Fix package.json to enable importmap pin#17swombat wants to merge 1 commit intoevilmartians:mainfrom
swombat wants to merge 1 commit intoevilmartians:mainfrom
Conversation
Member
|
Hey, thanks for putting this together! Before moving forward, I want to make sure I fully understand the issue you're hitting. From my side, it looks like using Also, If there’s a specific setup or error that breaks without this change, could you share more details? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there!
I love
harmony. I love Rails 8! Rails 8 lovesimportmap.importmapdoes not love@evilmartians/harmony, because the package.json doesn't include a rootBut DHH and others at this comment thread were helpful enough to point me to how to solve this problem. So, here's a pull request that fixes the issue, at least as far as Sonnet 3.7 is telling me (I'm not an
importmapornpmexpert).Hope this helps! In the meantime, I will do
importmap pin @evilmartians/harmony/base, but it'd be nice to fix this for everyone going forwards :-)Warm Regards,
Daniel