Added missing params and some type narrowing #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heliomance
commented
Jan 29, 2020
Heliomance
commented
- Split out leaves and branches for treemaps into different interfaces - no need to specify a size for a branch
- Added missing optional "position" param to XAxisProps and YAxisProps
- Added missing optional "style" param to DiscreteColorLegendProps
- Added missing optional "colorType" param to TreemapProps
- Added missing "ChartLabelProps" interface and "ChartLabel" class
- Added missing optional "color" prop to "data" in RadialChartProps
- Added missing optional "innerRadius" and "radius" props to RadialChartProps
- Added missing "height" prop to FlexibleWidthXYPlotProps
- Added missing "width" prop to FlexibleHeightXYPlotProps
- Type-narrowed makeHeightFlexible, makeWidthFlexible, and makeVisFlexible functions
- Assorted minor formatting changes from Prettier
- Split out leaves and branches for treemaps into different interfaces - no need to specify a size for a branch - Added missing optional "position" param to XAxisProps and YAxisProps - Added missing optional "style" param to DiscreteColorLegendProps - Added missing optional "colorType" param to TreemapProps - Added missing "ChartLabelProps" interface and "ChartLabel" class - Added missing optional "color" prop to "data" in RadialChartProps - Added missing optional "innerRadius" and "radius" props to RadialChartProps - Added missing "height" prop to FlexibleWidthXYPlotProps - Added missing "width" prop to FlexibleHeightXYPlotProps - Type-narrowed makeHeightFlexible, makeWidthFlexible, and makeVisFlexible functions - Assorted minor formatting changes from Prettier
|
If you want to download these types from NPM, I created 'react-vis-types' package InstallRepo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.