fix(parser): reconstruct braces in process substitution token loop#970
Merged
fix(parser): reconstruct braces in process substitution token loop#970
Conversation
The process substitution parser reconstructs command strings from tokens
but was missing handlers for LeftBrace and RightBrace. These tokens fell
through to the catch-all branch which silently dropped them, causing
`{ echo a; echo b; } | cat` inside `<(...)` to lose its group structure.
Closes #947
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ ... }piped to another command producing no output inside process substitution< <(...)LeftBraceandRightBracetokens were missing from the process substitution parser's token reconstruction loop, silently dropping themWhat
The process substitution parser reconstructs command strings from tokens to re-parse them. The match block handled
Pipe,Semicolon,And,Or, etc. but was missingLeftBraceandRightBrace. These fell through to the catch-all_branch which silently dropped them, turning{ echo a; echo b; } | catintoecho a; echo b; | cat.Test plan
process_subst_group_pipe,process_subst_group_pipe_tac,process_subst_group_pipe_sortcat < <({ echo "line1"; echo "line2"; } | cat)now outputs correctlycargo fmt --checkcleancargo clippycleanCloses #947