fix(security): sanitize internal state in error messages (TM-INF-016)#919
Merged
fix(security): sanitize internal state in error messages (TM-INF-016)#919
Conversation
Add sanitize_error_message() that strips host paths, IPv4/IPv6 addresses, and TLS details from error messages exposed to sandbox guests. Network client errors now use Error::network_sanitized() to wrap reqwest errors. Update threat model to mark TM-INF-016 fixed. Closes #909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitize_error_message()function that strips host paths, IPv4/IPv6 addresses, and TLS/SSL details from error messagesError::network_sanitized()to wrap reqwest errors before exposing to sandbox guestsError::io_sanitized()for wrapping std::io errorsTest plan
cargo test --lib -- sanitize— 5 unit tests passcargo test --test spec_tests -- bash_spec_tests— all spec tests passcargo clippy -- -D warningscleanCloses #909