fix(interpreter): isolate command substitution subshell state#917
Merged
fix(interpreter): isolate command substitution subshell state#917
Conversation
Command substitution $(...) runs in a subshell per POSIX/bash spec. Functions, variables, arrays, associative arrays, aliases, and cwd defined inside $(...) were leaking to the parent shell. Now all mutable state is snapshot/restored, matching the explicit subshell handler. Closes #910
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$(...)now properly isolates all mutable shell state: functions, variables, arrays, associative arrays, aliases, and cwd(...)handlerTest plan
cargo test --test spec_tests -- bash_spec_testspassessubst_function_isolation,subst_variable_isolation,subst_alias_isolationverify isolationcargo clippy -- -D warningscleancargo fmt --checkcleanCloses #910