fix(interpreter): handle ++/-- in complex arithmetic expressions#916
Merged
fix(interpreter): handle ++/-- in complex arithmetic expressions#916
Conversation
Pre-increment/decrement operators like `++i` in complex expressions (e.g., `(( ++i > 3 )) && break`) were incorrectly treated as standalone operations. The variable name extraction now properly identifies the variable and evaluates the remaining expression with the incremented value. Closes #903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(( ++i > N )) && breakexiting while loops on the first iterationexecute_arithmetic_with_side_effectsnow extracts the variable name from++var/--var, performs the side effect, and evaluates the remaining expression with the new value substitutedTest plan
cargo test --test spec_tests -- bash_spec_testspasses (1829 specs, 0 failures)arith_preincrement_and_breakandarith_predecrement_and_breakverify correct loop iteration countcargo clippy -- -D warningscleancargo fmt --checkcleanCloses #903