refactor(builtins): migrate base64 from manual arg parsing to ArgParser#890
Merged
refactor(builtins): migrate base64 from manual arg parsing to ArgParser#890
Conversation
chaliy
force-pushed
the
refactor/issue-880-argparser-base64
branch
from
7f1919b to
16e1c5c
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the base64 builtin’s argument handling to use the shared ArgParser utility instead of manual index-based parsing, aligning with the incremental migration effort in #880.
Changes:
- Replaced the
while i < ctx.args.len()loop with anArgParser-driven loop. - Implemented flag parsing via
flag_any,flag_value, andis_flag, while preserving existing behaviors like silently accepting--ignore-garbage. - Kept support for
--wrap=COLSwhile simplifying overall control flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace manual `while i < ctx.args.len()` index management with ArgParser API in the base64 builtin. Uses flag_any, flag_value, positional, and is_flag for cleaner argument handling. Part of #880
chaliy
force-pushed
the
refactor/issue-880-argparser-base64
branch
from
16e1c5c to
d543275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
while i < ctx.args.len()index management withArgParserAPI in thebase64builtinflag_any,flag_value,positional, andis_flagfor cleaner argument handlingTest plan
cargo clippycleancargo fmt --checkcleanPart of #880