fix(interpreter): handle compound array assignment in local builtin#888
Merged
fix(interpreter): handle compound array assignment in local builtin#888
Conversation
`local arr=(one two three)` produced an empty array because the compound assignment syntax was only recognized when -a or -A flags were present. Detect =(...) syntax regardless of flags in both function-scope and global-scope paths of execute_local_builtin. Also unskip nameref_local_dynamic_scope test that depended on this fix. Closes #877
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local arr=(one two three)produced an empty array because compound assignment syntax=(...)was only recognized when-aor-Aflags were present=(...)syntax regardless of flags in both function-scope and global-scope pathslocalwith compound assoc array assignmentsnameref_local_dynamic_scopetest that depended on this fix (22 skipped, down from 23)Test plan
local_array_compound_assignmentandlocal_array_compound_in_globalpassnameref_local_dynamic_scopenow passescargo test --all-featurespassescargo fmt --checkandcargo clippycleanCloses #877