fix(interpreter): expand special variables ($#, $?, etc.) in arithmetic#887
Merged
fix(interpreter): expand special variables ($#, $?, etc.) in arithmetic#887
Conversation
Special shell variables like $# were not recognized by expand_arithmetic_vars_depth because it only consumed alphanumeric/_ chars after $. Add handling for special variable characters (#, ?, $, !, @, *, -) so they resolve correctly inside (( )) arithmetic context. Closes #876
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$#,$?,$$were not expanded inside(( ))arithmetic becauseexpand_arithmetic_vars_depthonly consumed alphanumeric/underscore chars after$#,?,$,!,@,*,-) in the arithmetic variable expansionarith_special_var_hashandarith_special_var_questionTest plan
cargo test --all-featurespassescargo fmt --checkandcargo clippycleanCloses #876