fix(parser): expand $'\\n' ANSI-C quoting in concatenated function args#865
Merged
fix(parser): expand $'\\n' ANSI-C quoting in concatenated function args#865
Conversation
In read_continuation_into(), $'...' sequences were not recognized as ANSI-C quoting. The $ was consumed as a word character and the following '...' was treated as a regular single-quoted string, producing literal $\n instead of a newline. Add explicit $' detection in read_continuation_into() that delegates to read_dollar_single_quoted_content() for proper escape expansion. Closes #862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix ANSI-C quoting (
$'\n',$'\t', etc.) expansion when concatenated with adjacent quoted strings in function argument position.Why
In
read_continuation_into(),$'...'sequences were not recognized as ANSI-C quoting. The$was consumed as a regular word character and the following'...'was treated as a regular single-quoted string, producing literal$\ninstead of an actual newline character.This only affected concatenation in argument position (
show "a"$'\n'"b"). Variable assignment (x="a"$'\n'"b") worked correctly because it went throughread_word()which already had proper$'handling.How
Added explicit
$'detection inread_continuation_into()that uses lookahead to identify ANSI-C quoting and delegates to the existingread_dollar_single_quoted_content()for proper escape expansion.Tests
Added 7 spec tests covering:
$'\n'and$'\t'concatenated between double-quoted strings as function args$'\n'as sole argument$'\n'at start and end of concatenationCloses #862