Skip to content

fix(interpreter): resolve nameref for ${!ref[@]} key enumeration #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaliy merged 2 commits into from
Mar 27, 2026
Merged

fix(interpreter): resolve nameref for ${!ref[@]} key enumeration #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af175bf
fix(interpreter): resolve nameref for ${!ref[@]} key enumeration
chaliy Mar 26, 2026
9b42d19
fix(test): use sorted output for assoc array key enumeration test
chaliy Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/bashkit/src/interpreter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5897,11 +5897,12 @@ impl Interpreter {
result.push_str(&self.expand_array_access_part(name, index));
}
WordPart::ArrayIndices(name) => {
if let Some(arr) = self.assoc_arrays.get(name) {
let resolved = self.resolve_nameref(name);
if let Some(arr) = self.assoc_arrays.get(resolved) {
let mut keys: Vec<_> = arr.keys().cloned().collect();
keys.sort();
result.push_str(&keys.join(" "));
} else if let Some(arr) = self.arrays.get(name) {
} else if let Some(arr) = self.arrays.get(resolved) {
let mut indices: Vec<_> = arr.keys().collect();
indices.sort();
let index_strs: Vec<String> =
Expand Down
16 changes: 16 additions & 0 deletions crates/bashkit/tests/spec_cases/bash/nameref-assoc.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,22 @@ count_entries data
3
### end

### nameref_assoc_key_enumeration_string
# Nameref key enumeration via ${!ref[@]} in string context
show() {
local -n ref="$1"
for k in "${!ref[@]}"; do
echo "${k}=${ref[$k]}"
done | sort
}
declare -A m=([a]=1 [b]=2 [c]=3)
show m
### expect
a=1
b=2
c=3
### end

### nameref_overwrite_assoc_key
# Nameref overwrite existing key in associative array
update() {
Expand Down
Loading