fix(interpreter): reset last_exit_code in VFS subprocess isolation#850
Merged
fix(interpreter): reset last_exit_code in VFS subprocess isolation#850
Conversation
…ocess isolation Subprocess isolation in execute_script_content did not reset last_exit_code or nounset_error, causing the VFS script subprocess to inherit stale parent state. In real bash, a subprocess starts with $?=0. This caused set -euo pipefail scripts to see a non-zero $? from the parent shell, leading to false errexit failures. Closes #842
Documents the threat vector where parent last_exit_code was visible inside VFS script subprocesses, causing false set -e failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
last_exit_code = 0andnounset_error = Noneinexecute_script_contentsubprocess isolation, matching real bash behavior where subprocesses start with$? = 0last_exit_code, causingset -euo pipefailscripts to see stale non-zero exit codes and fail spuriouslyTest plan
exec_vfs_script_initial_exit_code_is_zero— verifies$?starts at 0 in subprocess after parentfalseexec_vfs_script_set_e_after_prior_failure—set -euo pipefailscript succeeds after parent non-zero exitexec_vfs_script_set_e_nested_scripts— nested VFS scripts withset -eand command substitutionCloses #842