fix(interpreter): treat invalid glob bracket expressions as literals#845
Merged
fix(interpreter): treat invalid glob bracket expressions as literals#845
Conversation
When [[ "$x" == "[]" ]] is evaluated, the incomplete bracket expression [] is now treated as literal characters instead of failing to match. Previously, invalid bracket expressions caused match_bracket_expr to return None, which was treated as a non-match. Closes #837
chaliy
force-pushed
the
fix/issue-837-glob-brackets
branch
from
23d602e to
b8528f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]) in glob patterns are now treated as literal characters instead of failing to matchmatch_bracket_exprreturnsNone(invalid), the[is compared literally against the value character, and the pattern iterator is rewound[a]continue to work as character classesTest plan
cond_bracket_literal_match—[[ "$x" == "[]" ]]matches when x is[]cond_single_bracket_literal—[[ "$x" == "[" ]]matches when x is[cond_valid_glob_bracket—[[ "a" == [a] ]]still works as glob patterncargo fmt --checkandcargo clippycleanCloses #837