fix(awk): treat # inside regex literals as literal, not comment#840
Merged
fix(awk): treat # inside regex literals as literal, not comment#840
Conversation
The awk normalizer now recognizes regex literals (/pattern/) in both pattern and action contexts. Previously, regex was only recognized inside braces, so /#/ in a pattern position caused # to be treated as a comment start. Closes #835
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pattern/) in both pattern and action contexts{ }braces, so/#/in a pattern position caused#to be treated as a comment start, resulting in "unterminated regex" errorsTest plan
awk_regex_hash_pattern—/#/matches lines containing#awk_regex_hash_caret—/^#/matches comment linesawk_regex_hash_no_match— non-hash regex still workscargo fmt --checkandcargo clippycleanCloses #835