feat(api): add BashBuilder::tty() for configurable terminal detection#830
Merged
feat(api): add BashBuilder::tty() for configurable terminal detection#830
Conversation
Closes #799 — add tty(fd, is_terminal) method to BashBuilder that configures whether [ -t fd ] reports a file descriptor as a terminal. Defaults remain false (non-interactive) for all FDs in the sandbox. The internal _TTY_N variable mechanism already existed; this exposes it through the public builder API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BashBuilder::tty(fd, is_terminal)method for configuring terminal detection[ -t fd ]and[[ -t fd ]]now respect per-FD configurationTest plan
tty_defaults_to_false— default behavior unchangedtty_configurable_via_builder— stdin/stdout configurable, unconfigured FDs still falsetty_test_builtin_bracket—[ -t ]single-bracket also worksCloses #799