feat(interpreter): exec with command argument — execute and don't return#815
Merged
feat(interpreter): exec with command argument — execute and don't return#815
Conversation
db1300d to
1d37fcf
Compare
1d37fcf to
526eb03
Compare
chaliy
added a commit
that referenced
this pull request
Mar 26, 2026
PR #815 made `exec cmd` run within VFS sandbox instead of blocking. The JS security test still expected `exec ls` to fail, but `ls` is a builtin that succeeds in the sandbox. Changed to test `exec /bin/bash` which correctly fails (external binary not in VFS).
chaliy
added a commit
that referenced
this pull request
Mar 26, 2026
PR #815 made `exec cmd` run within VFS sandbox instead of blocking. The JS security test still expected `exec ls` to fail, but `ls` is a builtin that succeeds in the sandbox. Changed to test `exec /bin/bash` which correctly fails (external binary not in VFS).
4 tasks
chaliy
added a commit
that referenced
this pull request
Mar 26, 2026
PR #815 made `exec cmd` run within VFS sandbox instead of blocking. The JS security test still expected `exec ls` to fail, but `ls` is a builtin that succeeds in the sandbox. Changed to test `exec /bin/bash` which correctly fails (external binary not in VFS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n-
exec cmd args...now resolves and executes the command, then exits the current script/shell with its exit code\n- Subsequent statements afterexecare not executed (usesControlFlow::Return)\n- FD-only exec (no command) continues to work as before\n\nCloses #794\nCloses #797\n\n## Test plan\n\n- [x] exec replaces execution (subsequent statements skipped)\n- [x] exec propagates exit code\n- [x] exec with builtin command\n- [x] exec passes arguments\n- [x] exec FD redirections still work\n- [x]cargo test --all-featuresgreen\n- [x]cargo clippyandcargo fmtclean