feat(scripted_tool): add ScriptingToolSet with discovery mode support#534
Merged
feat(scripted_tool): add ScriptingToolSet with discovery mode support#534
Conversation
ScriptingToolSet wraps ScriptedTool with mode-controlled system_prompt(): - Exclusive (default): full schemas in prompt, LLM knows everything upfront - WithDiscovery: semantic descriptions only, LLM uses discover/help builtins New types: ScriptingToolSet, ScriptingToolSetBuilder, DiscoveryMode. Implements Tool trait, delegates execution to inner ScriptedTool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScriptingToolSet, a higher-level wrapper aroundScriptedToolthat controlssystem_prompt()generation based onDiscoveryModediscoverandhelpbuiltins — best for large tool sets or alongside other toolsmcp.rs(unusedmut)What
ScriptingToolSetstruct implementing theTooltrait, delegating execution to innerScriptedToolScriptingToolSetBuilderwith fluent API:.tool(),.env(),.limits(),.short_description(),.with_discovery()DiscoveryModeenum (Exclusive|WithDiscovery)Why
When
ScriptedToolis used alongside other discovery-capable tools, full schemas in the system prompt waste tokens.ScriptingToolSetlets the caller choose: full schemas upfront (exclusive) or semantic-only with discover/help builtins (discovery mode).Test plan
cargo fmt --checkpassescargo clippy --all-targets -- -D warningspassescargo test --all-featurespasses (all 1575 tests)scripted_toolfeature