fix(builtins): prevent awk parser panic on multi-byte UTF-8#476
Merged
Conversation
The awk parser used byte offsets with chars().nth() (char index), causing panics when multi-byte UTF-8 appeared in comments, strings, or regex patterns. Added current_char()/advance() helpers for safe char-boundary handling and replaced all chars().nth(byte_offset) patterns with byte-safe slicing. Closes #395
chaliy
force-pushed
the
claude/fix-395-Y2nIj
branch
from
5f75382 to
49a1814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
current_char()andadvance()helpers for char-boundary safe parsingchars().nth(self.pos)calls withcurrent_char()matches_keywordlookahead to use slice-based char accessCloses #395