fix(test): increase cpu exhaustion timeout bound for coverage#432
Merged
fix(test): increase cpu exhaustion timeout bound for coverage#432
Conversation
The threat_cpu_exhaustion_timeout test asserted elapsed < 15s, but under tarpaulin coverage instrumentation the overhead pushes execution past 15s (observed 15.22s in CI). Increase bound to 30s. https://claude.ai/code/session_018tdhmNszTYmKk4hkqsuCSz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threat_cpu_exhaustion_timeouttest was failing in the Coverage CI job (tarpaulin) because the assertionelapsed < 15swas too tight — tarpaulin instrumentation overhead caused the test to take 15.22sTest plan
cargo test threat_cpu_exhaustion_timeoutpasses locally