fix(interpreter): count unicode chars in ${#x} and add printf \u/\U escapes#378
Merged
fix(interpreter): count unicode chars in ${#x} and add printf \u/\U escapes#378
Conversation
chaliy
force-pushed
the
claude/fix-362-unicode-Vvs93
branch
from
a37a60a to
e04a738
Compare
…scapes
- Change ${#x} from .len() (byte count) to .chars().count() (character
count) so `x=café; echo ${#x}` returns 4 instead of 5
- Add \uHHHH and \UHHHHHHHH unicode escape handling to printf format
strings and %b expand_escapes
- Add parse_unicode_escape helper function to printf builtin
- Remove 3 ### skip: markers from unicode.test.sh, replace with
### bash_diff: for locale-dependent differences
- Add unit tests for printf unicode escapes
Closes #362
chaliy
force-pushed
the
claude/fix-362-unicode-Vvs93
branch
from
e04a738 to
1b44842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${#x}to count Unicode characters instead of bytes:x=café; echo ${#x}now correctly returns4instead of5\uHHHH(4-digit) and\UHHHHHHHH(8-digit) Unicode escape handling to the printf builtin, both in format strings and%bargument expansion### skip:markers fromunicode.test.shand replace with### bash_diff:markers (system bash behavior differs based on locale)Test plan
cargo fmt --checkcleancargo clippy --all-targets --all-features -- -D warningscleantest_unicode_escape_u,test_unicode_escape_big_u,test_unicode_escape_ascii,test_unicode_escape_in_expandCloses #362