feat(tool): add per-tool-call timeout_ms to ToolRequest#350
Merged
Conversation
Add optional `timeout_ms` field to `ToolRequest` that allows callers to set per-call execution timeouts. When the timeout expires, execution is aborted and a response with exit_code=124 is returned (matching bash `timeout` convention). - Add `timeout_ms: Option<u64>` with `#[serde(default)]` for backward compat - Wrap both `execute` and `execute_with_status` with `tokio::time::timeout` - Add `ToolRequest::new()` convenience constructor - Add tests for timeout, no-timeout, and serde deserialization - Update tool contract spec (009) Closes #337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout_msfield toToolRequestfor per-call execution timeoutstimeoutconvention)executeandexecute_with_statusrespect the timeout#[serde(default)]so existing JSON without it still worksTest plan
sleep 10with 100ms timeout (exit 124)ToolRequest::new()convenience constructortimeout_msCloses #337