feat(iconv): support //translit transliteration mode#1136
Merged
Conversation
Parses //translit suffix on target encoding (e.g. ascii//translit). When enabled, non-ASCII characters are mapped to closest ASCII equivalents (é→e, ö→o, ñ→n, etc.) before encoding, matching GNU iconv behavior used by bashblog and other tools. Closes #1117
chaliy
force-pushed
the
feat/issue-1117-iconv-translit
branch
from
0b4f298 to
6c8c891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//translitsuffix on target encoding (e.g.ascii//translit)?(matching GNU iconv behavior)Test plan
test_translit_to_ascii— café → cafetest_translit_multiple_diacritics— naïve → naivetest_translit_german— Héllo Wörld → Hello WorldCloses #1117