feat(js): expose real filesystem mounts with per-mount readOnly support#1077
Merged
feat(js): expose real filesystem mounts with per-mount readOnly support#1077
Conversation
Add MountConfig napi object and mounts option to BashOptions for configuring real filesystem mounts at construction time. Add mountReal() and unmount() runtime methods to both Bash and BashTool classes. Mount configs are stored in SharedState and re-applied on reset(). Also fixes pre-existing broken code (missing shared_state_from_opts function and stale build_bash references in BashTool::reset). Closes #1066
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MountConfignapi object andmountsoption toBashOptionsfor configuring real filesystem mounts at construction time (host path, optional VFS path, optional readOnly flag defaulting to true)mountReal(hostPath, vfsPath, readOnly?)andunmount(vfsPath)runtime methods to bothBashandBashToolclassesSharedStateand re-applied onreset()for consistencyrealfsfeature in bashkit-js Cargo.toml dependencyshared_state_from_optsfunction and fix stalebuild_bashreference inBashTool::resetCloses #1066
Test plan
cargo check -p bashkit-jscompiles cleanlycargo fmtpassesruntime_mount_*/runtime_unmounttests pass inrealfs_tests.rs