fix(parser): handle >= and <= operators in (( )) arithmetic commands#1023
Merged
fix(parser): handle >= and <= operators in (( )) arithmetic commands#1023
Conversation
The tokenizer splits >= into RedirectOut + Word("=") and <=
into RedirectIn + Word("="), causing the (( )) parser to
produce malformed expressions. Added lookahead in the arithmetic
command parser to combine these tokens back into >= and <=.
Also handles N>= (e.g., 3>=5) where the tokenizer produces
RedirectFd(N) + Word("=...").
Closes #967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=and<=operators in(( ))arithmetic commands always evaluating incorrectly>=intoRedirectOut+Word("=")and<=intoRedirectIn+Word("="), which caused the(( ))parser to produce malformed expressions>=and<=N>=(e.g.,3>=5) where the tokenizer producesRedirectFd(N)+Word("=...")Why
(( 3 >= 5 ))always returned exit code 0 (true) because the=was dropped from the expression, producing3> = 5which was misinterpreted as an assignment returning 5 (non-zero → true).Tests
arith_cmd_ge_false,arith_cmd_ge_true,arith_cmd_ge_equal,arith_cmd_ge_nospace,arith_cmd_le_nospaceCloses #967