fix(parser): cap lookahead in looks_like_brace_expansion#1019
Merged
Conversation
Closes #997 — looks_like_brace_expansion scanned to end of input for each unmatched {, causing O(n^2) total scanning on pathological input. Limits scan to 10,000 characters per invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
looks_like_brace_expansionlookahead to 10,000 characters{charactersCloses #997
Test plan
brace_expansion_lookahead.test.shwith 4 casescargo test --all-featurespassescargo clippy -- -D warningsclean