fix(parser): enforce subst depth limit in unquoted cmdsub#1018
Merged
Conversation
Closes #996 — read_word used simple parenthesis counting for $() in unquoted context, bypassing the max_subst_depth limit that was enforced in double-quoted strings. Now tracks $( nesting depth and stops recursing deeper when the limit is reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_subst_depthin unquoted$()context inread_word, matching the limit already enforced in double-quoted strings$()from bypassing depth limitCloses #996
Test plan
cmdsub_depth_unquoted.test.shwith 3 casesparse_incomplete_command_subtest still passescargo test --all-featurespassescargo clippy -- -D warningsclean