fix(interpreter): cap global pattern replacement result size#1017
Merged
fix(interpreter): cap global pattern replacement result size#1017
Conversation
Closes #995 — global pattern replacement ${var//pattern/repl} could produce unbounded output when replacement is longer than the matched text. Adds MAX_EXPANSION_RESULT_BYTES (10MB) check to both simple string replacement and recursive glob replacement paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${var//pattern/repl}) output sizeCloses #995
Test plan
replace_pattern_limit.test.shwith 3 casescargo test --all-featurespassescargo clippy -- -D warningsclean