fix(interpreter): cap glob_match calls in remove_pattern_glob#1016
Merged
fix(interpreter): cap glob_match calls in remove_pattern_glob#1016
Conversation
Closes #994 — remove_pattern_glob called glob_match for every split point of the input string, causing O(n^2) CPU exhaustion on long strings with bracket expressions. Caps at 10,000 invocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glob_matchinvocations inremove_pattern_globto 10,000 to prevent O(n^2) CPU exhaustion[a]*on long strings no longer cause quadratic scanningCloses #994
Test plan
glob_match_cap.test.shwith 4 casescargo test --all-featurespassescargo clippy -- -D warningsclean