fix(interpreter): save/restore memory_budget in subshell/cmdsub#1015
Merged
fix(interpreter): save/restore memory_budget in subshell/cmdsub#1015
Conversation
…substitution Closes #993 — memory_budget was not saved/restored alongside variables, arrays, and functions in subshell, command substitution, and script execution paths. This caused budget desync where the budget either inflated (preventing legitimate variable creation) or undercounted (allowing limit bypass). Also adds recompute_from_state to MemoryBudget for restore_shell_state snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
memory_budgetalongside other state in subshell, command substitution, and script execution pathsMemoryBudget::recompute_from_stateforrestore_shell_statesnapshot restorationCloses #993
Test plan
memory_budget_desync.test.shwith 3 casescargo test --all-featurespassescargo clippy -- -D warningscleancargo fmt --checkclean