fix(builtins): emit stderr warning when sed branch loop limit is reached#1012
Merged
fix(builtins): emit stderr warning when sed branch loop limit is reached#1012
Conversation
Closes #1005 — the sed branch/label execution loop silently stopped at 1000 iterations, producing incorrect output without warning. Now emits a diagnostic message on stderr when the limit is hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What & Why
The sed branch execution loop silently stopped at 1000 iterations, producing silently truncated output. This is a data integrity issue — scripts depending on sed loops would get incorrect results without any indication. Now emits
sed: warning: branch/label loop limit (1000) reached on line N; output may be truncated.Tests Added
test_sed_branch_loop_limit_emits_warning— verifies warning on stderr when limit hittest_sed_normal_branch_no_warning— verifies no warning for normal sed usageCloses #1005