Skip to content

Removable Storage #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MosesMuiru wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Removable Storage #794

MosesMuiru wants to merge 20 commits into from

Conversation

@MosesMuiru
Copy link
Contributor

@MosesMuiru MosesMuiru commented Sep 9, 2025 •
edited
Loading

This PR is still WIP

Checklist

  • Detect removable storage
  • Select footage for copying
  • Copy
Screenshot from 2025-09-09 19-17-40

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

📦 To trigger a firmware build, comment /build below.
To build a specific target, comment /build <target> with on of the following targets
Valid target names:

  • ex_nvr_rpi4
  • ex_nvr_rpi5
  • giraffe

You can also specify a custom version: /build <target> version=<version>
Examples:
/build version=1.0.0-test
/build ex_nvr_rpi5 version=1.0.0-test.123

If no version is specified, one will be generated automatically.

@MosesMuiru MosesMuiru marked this pull request as draft September 10, 2025 11:23
@MosesMuiru MosesMuiru self-assigned this Oct 13, 2025
@MosesMuiru
Copy link
Contributor Author

MosesMuiru commented Oct 22, 2025

commit - e3d4ba7 - Contains pop up for selecting duration, format, and destination i.e detected usb. The below ui is not final, please drop suggestions.

Screenshot from 2025-10-22 20-47-15

@MosesMuiru MosesMuiru requested a review from gBillal October 22, 2025 18:45
@MosesMuiru
modified the pop up filter to include device, how recordings are save…
b94818a 
…d in the removable storage(start_date_to_end_date) format, functionality to cp one min video to removable storage
@MosesMuiru
Copy link
Contributor Author

MosesMuiru commented Oct 24, 2025

  • commit b94818a
  • The video below shows how to export a one-minute clip to removable storage. You can also export all the one-minute recordings as a single video.
Screencast.from.2025-10-24.09-43-38.mp4

@MosesMuiru
Merge branch 'master' of github.com:evercam/ex_nvr into feat-removabl…
e4eac5e 
…e-storage
@MosesMuiru
fix
9de69c7 
contains notification for when a usb is connected, removed the removeble storage page
@MosesMuiru
export rewrite to use the concatenator function, group recordings chu…
2dd95ff 
…cks to a 1 hr
@MosesMuiru MosesMuiru changed the title Removable Storage(WIP) - POC Removable Storage(WIP) Nov 25, 2025
@MosesMuiru
Copy link
Contributor Author

MosesMuiru commented Nov 28, 2025

ui updates

2025-11-28.10-57-11.mp4

@MosesMuiru
updated export stepper
73027a4
@MosesMuiru
changes: contains updated ui with validations in place. Updated the g…
7575043 
…rouping rec into chunks to use ecto limit as the base, accurate calculation of recordings size
@MosesMuiru
Copy link
Contributor Author

MosesMuiru commented Dec 4, 2025

A video showing updated ui export journey

Screencast.from.2025-12-04.20-02-54.webm

@MosesMuiru
Copy link
Contributor Author

MosesMuiru commented Dec 7, 2025

The ui below shows:

  • blue progress bar as feedback during export process
  • renamed usb to External drive
Screencast.from.2025-12-07.10-20-32.webm

gBillal
gBillal requested changes Dec 10, 2025
View reviewed changes
ui/lib/ex_nvr/removable_storage/mounter.ex Outdated
@@ -0,0 +1,91 @@
defmodule ExNvr.RemovableStorage.Mounter do
Copy link
Member

@gBillal gBillal Dec 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this ??
We discussed before that ex_nvr should not know anything about USB and any device. Delete all this code.

ui/lib/ex_nvr_web/components/sidebar.ex Outdated
attr(:children, :list, default: [])
attr(:current_path, :string, default: nil)
attr(:is_active, :boolean, default: false)
attr(:role, :atom, default: nil)
Copy link
Member

@gBillal gBillal Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore the formatting

ui/lib/ex_nvr_web/ets_server.ex Outdated
@@ -0,0 +1,52 @@
defmodule ExNVRWeb.ETSServer do
Copy link
Member

@gBillal gBillal Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need an ets ?

Copy link
Contributor Author

@MosesMuiru MosesMuiru Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove that, It was for state manager for the export stepper

ui/lib/ex_nvr_web/router.ex Outdated
plug(:put_root_layout, {ExNVRWeb.Layouts, :root})
plug(:protect_from_forgery)
plug(:put_secure_browser_headers)
plug(:fetch_current_user)
Copy link
Member

@gBillal gBillal Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your formatter and do not run mix format from the root folder.

@MosesMuiru MosesMuiru changed the title Removable Storage(WIP) Removable Storage Dec 19, 2025
@MosesMuiru MosesMuiru marked this pull request as ready for review December 19, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gBillal gBillal gBillal requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@MosesMuiru MosesMuiru

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A method for copying footage to removable (USB?) storage

3 participants

@MosesMuiru @gBillal