Added:

[crsndr]

$ldap_group_search_base = 'ou=Groups,dc=org',
$ldap_user_search_base = 'ou=People,dc=org',

parameters

[jlambert121]

Thanks for the PR. Would you line up the properties in the class and I think this property should start undefined and only set the parameters when set. If you could add some tests to make sure the properties are set/unset too.

[jlambert121]

Thanks for updating that. I was just ready to merge it and noticed there wasn't any tests around this. Sorry I missed that the first time, could you put a test in for default and for set and then it's good to go!

[crsndr]

Is there still anything that should be done before it can be merged?

[jlambert121]

Sorry - GH doesn't email with just code changes so I didn't see them. Would you add a test to make sure the undef parameter isn't added, squish it all into a single commit and I'll merge it. If you'd throw a comment on that would be great so I don't miss it. Thanks!