Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes operator precedence issues in an expression parser by ensuring that comparison operators (===, >) have higher precedence than logical operators (&& and ||). The fix introduces a new parsing method that stops at logical operators, allowing comparisons to be evaluated first.
- Added
parseExpressionUntilLogical()method to handle operator precedence correctly - Updated comparison operators to use the new parsing method instead of recursive
parseExpression() - Added comprehensive test cases covering various combinations of comparison and logical operators
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Parser/ExpressionParser.php | Implements operator precedence fix by adding new parsing method and updating comparison operator parsing |
| tests/unit/cases/precedence/*.txt | Adds test cases for equality/greater-than operators with logical AND/OR operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rieschl
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.