Upgrade static analysis tools and fix uncovered issues#40
Merged
MidnightDesign merged 7 commits into0.2.xfrom Sep 29, 2025
Merged
Upgrade static analysis tools and fix uncovered issues#40MidnightDesign merged 7 commits into0.2.xfrom
MidnightDesign merged 7 commits into0.2.xfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades static analysis tools (PHPStan, Psalm, PHPUnit, and Infection) to their latest versions and addresses issues uncovered by the upgraded tooling. The changes focus on modernizing code to use PHP 8+ features and fixing newly detected issues.
- Upgraded major dependencies including PHPStan 2.x, PHPUnit 12.x, Psalm 6.x, and Infection 0.31.x
- Replaced deprecated
@dataProviderannotations with#[DataProvider]attributes across all test files - Added
#[Override]attributes to method overrides and simplified type equality logic
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| composer.json | Updated dependency versions for static analysis and testing tools |
| infection.json | Added schema validation and PHPStan integration |
| tests/unit/*.php | Modernized test files with DataProvider attributes and new test methods |
| src/*.php | Added Override attributes and simplified implementation logic |
Comments suppressed due to low confidence (1)
src/Type.php:203
- Removing the check for 'any' type as subtype breaks the type system semantics. The 'any' type should be a subtype of all types, making this removal incorrect.
return false;
}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rieschl
previously approved these changes
Sep 26, 2025
c180f35 to
aecd31f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.