Skip to content

Upgrade static analysis tools and fix uncovered issues#40

Merged
MidnightDesign merged 7 commits into0.2.xfrom
upgrade-static-analysis-tools
Sep 29, 2025
Merged

Upgrade static analysis tools and fix uncovered issues#40
MidnightDesign merged 7 commits into0.2.xfrom
upgrade-static-analysis-tools

Conversation

@MidnightDesign
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades static analysis tools (PHPStan, Psalm, PHPUnit, and Infection) to their latest versions and addresses issues uncovered by the upgraded tooling. The changes focus on modernizing code to use PHP 8+ features and fixing newly detected issues.

  • Upgraded major dependencies including PHPStan 2.x, PHPUnit 12.x, Psalm 6.x, and Infection 0.31.x
  • Replaced deprecated @dataProvider annotations with #[DataProvider] attributes across all test files
  • Added #[Override] attributes to method overrides and simplified type equality logic

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.

File Description
composer.json Updated dependency versions for static analysis and testing tools
infection.json Added schema validation and PHPStan integration
tests/unit/*.php Modernized test files with DataProvider attributes and new test methods
src/*.php Added Override attributes and simplified implementation logic
Comments suppressed due to low confidence (1)

src/Type.php:203

  • Removing the check for 'any' type as subtype breaks the type system semantics. The 'any' type should be a subtype of all types, making this removal incorrect.
            return false;
        }

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

rieschl
rieschl previously approved these changes Sep 26, 2025
@MidnightDesign MidnightDesign force-pushed the upgrade-static-analysis-tools branch from c180f35 to aecd31f Compare September 29, 2025 09:09
@MidnightDesign MidnightDesign merged commit 3e05198 into 0.2.x Sep 29, 2025
25 checks passed
@MidnightDesign MidnightDesign deleted the upgrade-static-analysis-tools branch September 29, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants