feat(ai/bedrock): add Amazon Bedrock provider support

[vidurkhanal]

• Added aws-config and aws-sdk-bedrockruntime dependencies to enable Amazon Bedrock integration.
• Implemented AmazonBedrockProvider with support for object generation via the Bedrock Converse API.
• Updated AIProvider to route object generation requests to Bedrock when selected.
• Introduced error handling for Bedrock-specific and deserialization errors.
• Refactored provider builder for Bedrock, including region, credentials, and header management.
• Added test scaffolding for Bedrock provider.
• Updated error types and retry logic to handle new Bedrock error cases.

[greptile-apps]

Greptile Summary

This PR adds Amazon Bedrock provider support to the AI module, implementing text and object generation via the Bedrock Converse API.

Key Changes:

• Implemented AmazonBedrockProvider with GeneratesText and GeneratesObject traits
• Added AmazonBedrockProviderBuilder with region and credential configuration
• Integrated provider into AIProvider enum routing system
• Added BedrockConverseError variant to error handling with retry logic
• Included test scaffolding for both text and object generation

Critical Issues:

• unsafe block used to set environment variables (lines 299-305) creates potential data races and violates Rust safety - credentials should be passed directly to AWS SDK
• Base64 image data not decoded before passing to AWS API (line 200-202)
• Method naming typo: normalizer_generate_object_request should be normalize_generate_object_request

Minor Issues:

• default_headers field defined but never used
• Cross-provider dependency on OpenAIProvider for utility method
• Test placeholder typos and todo!() instead of unimplemented!()

Confidence Score: 2/5

• Not safe to merge - contains critical security and logic issues
• The unsafe environment variable manipulation creates thread-safety issues, and the base64 image handling bug will cause runtime failures. The typo in the method name will cause compilation errors.
• Pay close attention to crates/umem_ai/src/providers/amazon_bedrock.rs - contains unsafe code block and logic errors that must be fixed

Important Files Changed

Filename	Overview
crates/umem_ai/src/providers/amazon_bedrock.rs	Added AmazonBedrockProvider with text/object generation support, but contains critical security issue with unsafe environment variable setting and typo in method name
crates/umem_ai/src/response_generators/mod.rs	Added BedrockConverseError variant to error enum following project conventions
crates/umem_ai/src/utils.rs	Added retry logic for Bedrock errors, consistent with existing error handling patterns
crates/umem_ai/src/lib.rs	Integrated AmazonBedrockProvider into AIProvider enum and routing logic, following existing patterns

Sequence Diagram

sequenceDiagram
    participant Client
    participant AIProvider
    participant AmazonBedrockProvider
    participant AWSBedrockClient
    participant BedrockAPI

    Client->>AIProvider: generate_object(request)
    AIProvider->>AIProvider: match provider type
    AIProvider->>AmazonBedrockProvider: generate_object(request)
    
    AmazonBedrockProvider->>AmazonBedrockProvider: normalize_generate_object_request()
    Note over AmazonBedrockProvider: Extract system message from OpenAIProvider<br/>Build user messages with schema
    
    AmazonBedrockProvider->>AWSBedrockClient: converse().send()
    AWSBedrockClient->>BedrockAPI: HTTP Request (Converse API)
    
    alt Success
        BedrockAPI-->>AWSBedrockClient: Converse Response
        AWSBedrockClient-->>AmazonBedrockProvider: ConverseOutput
        AmazonBedrockProvider->>AmazonBedrockProvider: Extract text from output message
        AmazonBedrockProvider->>AmazonBedrockProvider: Deserialize JSON to type T
        AmazonBedrockProvider-->>AIProvider: GenerateObjectResponse<T>
        AIProvider-->>Client: Result<GenerateObjectResponse<T>>
    else Error
        BedrockAPI-->>AWSBedrockClient: SDK Error
        AWSBedrockClient-->>AmazonBedrockProvider: Error
        AmazonBedrockProvider-->>AIProvider: ResponseGeneratorError::BedrockConverseError
        AIProvider-->>Client: Err(ResponseGeneratorError)
    end

Loading

[greptile-apps]

_{6 files reviewed, 9 comments}

_{Edit Code Review Agent Settings | Greptile}