Skip to content

Conversation

@Zhomart
Copy link

@Zhomart Zhomart commented Nov 19, 2021

Update dex, sqlite, mysql, mongodb, postgres deps for compatibility with the latest deno v1.16.2

  • dex: update to the version that uses std@0.115.1, instead
    of the latest version of jspm-core, which could be dangerous
    when jspm-core pushes the latest breaking code.
    Use the latest deno node deps  aghussb/dex#3
  • sqlite: update to v3.1.3, it contains breaking changes
    so this PR fixes them too.
  • mysql: minor upgrade to v2.10.1 (from v2.10.0)
  • mongodb: update to v0.28.0, because the old version
    is not compatible with the latest deno.
  • postgres: update to v0.14.2 and fix postgres-connectors.ts,
    because the old version is not compatible with the latest deno.

The changes are tested on deno v1.16.2.

Fixes: #303, #302

dex: update to the version that uses std@0.115.1, instead
     of the latest version of jspm-core, which could be dangerous
     when jspm-core pushes the latest braking code.
     aghussb/dex#3
sqlite: update to v3.1.3, it contains braking changes
        so this PR fixes them too.
mysql: minor upgrade to v2.10.1 (from v2.10.0)
mongodb: update to v0.28.0, because the old version
         is not compatible with the latest deno.
postgres: update to v0.14.2 and fix update postgres-connectors,
          because the old version is not compatible with the
          latest deno.

The changes are tested on deno v1.16.2.
@Zhomart Zhomart marked this pull request as ready for review November 21, 2021 05:26
@Zhomart Zhomart changed the title Update dex and mongodb deps Update dex, sqlite, mysql, mongodb, postgres deps for compatibility with the latest deno v1.16.2 Nov 21, 2021
Copy link
Owner

@eveningkid eveningkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for your work Zhomart, it is highly appreciated!

For some reason, I missed the email and then got many notifications from linked issues. I am happy your work will help everybody else!

You'll find a few comments/questions below. If I can get your feedback on these, that would be helpful to move this forward.

Have a great day, talk soon :)

@Zhomart
Copy link
Author

Zhomart commented Dec 11, 2021

Thanks eveningkid for reviewing!

Copy link
Owner

@eveningkid eveningkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for making all the changes :)

Please find below the last tiny tweak and we're good to merge!

@eveningkid
Copy link
Owner

Cool, I'll merge and create a new release!

Have a great day Zhomart :)

@eveningkid eveningkid self-requested a review December 13, 2021 16:50
@l3onh4rd
Copy link

Thank you for your great work!!! For me this fixed my problem ;) It even works with deno version 1.16.4. Hopefully it won't break with tomorrow releasing version 1.17.0...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript check not passing after Deno 1.13.2

4 participants