feat!: add multi tenant support for all assemblies #37
Conversation
emit events during OwnerCap transfer
…ld-contracts into feat/multi-tenant-for-assemblies
…at/character-hardening
…ld-contracts into feat/multi-tenant-for-assemblies
vayan
left a comment
vayan
left a comment
There was a problem hiding this comment.
looks good! Glad that we're multi TEAnant now.
0xxlegolas
changed the title
ccp-bofai
left a comment
ccp-bofai
left a comment
There was a problem hiding this comment.
When I read the code I see "item_id" as "the id of an item", I see "character_id" as " the id of a character", I see "type_id" as the "id of a type". This establishes a pattern which is quite clear and understandable. "game_id" on the other hand is not "the id of a game". I am guessing it is "in_game_item_id".
I am also finding key: DerivationKey, not very obvious to read. I am guessing that it is a derived object id of an in game item id and tenant id. Wondering if it should be item_tid (and document that "tid" is "tenanted id") or "tenanted_item_id". I could quite easily see people reading "key", and then thinking of public/private key related things, perhaps even an address; but I don't see any suggestion of what is in it.
ccp-bofai
left a comment
ccp-bofai
left a comment
There was a problem hiding this comment.
LGTM thanks for the readability changes
Uh oh!
There was an error while loading. Please reload this page.