enhancement: add custom max pixel length functionality#43
Open
hidayahapriliansyah wants to merge 1 commit intoevanw:mainfrom
Open
enhancement: add custom max pixel length functionality#43hidayahapriliansyah wants to merge 1 commit intoevanw:mainfrom
hidayahapriliansyah wants to merge 1 commit intoevanw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using Thumbhash, I wanted to generate image thumbnails with very small file sizes, ideally less than 1KB. To achieve this, I needed the ability to set a custom maximum pixel length, such as 16 pixels. However, I found that Thumbhash currently enforces a default minimum pixel length of 32 pixels, which limits flexibility.
I made changes to the code to allow users to define their own custom maximum pixel length when generating thumbnails. This enhancement provides more control over the size of the thumbnails, making it possible to optimize them for smaller file sizes when needed. A demo of this updated functionality can be found here: https://thumbhash-generator.vercel.app/