feat: add check-compat-table script and feature limits tests#4403
Open
zerdos wants to merge 1 commit intoevanw:mainfrom
Open
feat: add check-compat-table script and feature limits tests#4403zerdos wants to merge 1 commit intoevanw:mainfrom
zerdos wants to merge 1 commit intoevanw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces safeguards to ensure the compatibility tables and feature flags remain within their supported limits, and adds a Makefile check to help maintain up-to-date compatibility tables. These changes help prevent subtle errors due to bitmask overflows and improve developer workflows.
Feature flag capacity safeguards:
js_table.goto ensure theJSFeaturebitmask does not exceed 64 features, preventing silent overflow errors.compat_test.goto check thatjsTableandcssTabledo not exceed their respective bitmask capacities (64 for JS, 16 for CSS), providing clear error messages if limits are breached.Developer workflow improvements:
check-compat-tableMakefile target to verify thatjs_table.goandcss_table.goare up to date, alerting developers when changes need to be committed.