Support screen resolutions above 992 pixels wide#12
Open
jepler wants to merge 2 commits intoevansm7:mainfrom
Open
Support screen resolutions above 992 pixels wide#12jepler wants to merge 2 commits intoevansm7:mainfrom
jepler wants to merge 2 commits intoevansm7:mainfrom
Conversation
This works in cursory testing in the finder at e.g. 1280x720 (115200 bytes of screen RAM) Widths 1024 pixels and above need extra patching because of sites where the row width in bytes is loaded with signed 8-bit moveq. The existing simpler patches are preserved when this is not needed, especially as hidecursor now does a fair amount of extra work re-loading d0 in every iteration of the hide loop, which simplified the patch.
it's probably microscopically faster
jepler
changed the title
jepler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works in cursory testing in the finder at e.g. 1280x720 (115200 bytes of screen RAM)
Widths 1024 pixels and above need extra patching because of sites where the row width in bytes is loaded with signed 8-bit moveq. The existing simpler patches are preserved when this is not needed.