Fix issue with static files on Windows#474
Open
marcperrinoptel wants to merge 2 commits intoevansd:mainfrom
Open
Fix issue with static files on Windows#474marcperrinoptel wants to merge 2 commits intoevansd:mainfrom
marcperrinoptel wants to merge 2 commits intoevansd:mainfrom
Conversation
…url before calling finders.find (which really does need an OS-standardized path as input)
for more information, see https://pre-commit.ci
Contributor
|
This needs a test to ensure there aren't regressions. |
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #472
also https://code.djangoproject.com/ticket/34341
The probable takeaway from the discussion on Django side is that
finders.find()is really supposed to be called with an OS-standardized path.I've mimicked what Django does to an url before calling
finders.find():url2pathname) is obvious enoughposixpath.normpath, plus.lstrip('/')) seems debatable considering that we're already afterurl2pathname, but for the sake of mimicking Django I've included it