Conversation
c114d60 to
128b704
Compare
|
@adamchainz could this be merged once rebase? I think this feature would be great to give users flexibility. |
adamchainz
left a comment
There was a problem hiding this comment.
I haven't thought too hard about whether this is a good solution. It's a large API area to expose to users.
The PR is also far from ready: there are no tests, the documentation needs expanding significantly to describe how to subclass Compressor and what methods can be customized, there are no non-django docs, and there's no changelog entry.
I would also like to see some evidence of experimentation with alternative approaches, even just monkey-patching the current version of Whitenoise to see how easy it is to skip files that way.
9335692 to
0fec8c0
Compare
|
@adamchainz I have rebased to current Have you made some decision whether you want this in the project or not? I would like to work on the tests and documentation, but I don't want to waste my time if it doesn't eventually get merged.
I am not sure how to deal with this. Of course it would be possible with monkey-patching, but it would be possible, but it would be very ugly. |
66fece3 to
042dd97
Compare
eee412a to
7aa187c
Compare
for more information, see https://pre-commit.ci
|
@adamchainz I have updated this, wrote tests and added some more documentation. |
Fixes #279.