Skip to content

To Do list: add & remove#2

Open
evans22j wants to merge 9 commits intomainfrom
add-remove
Open

To Do list: add & remove#2
evans22j wants to merge 9 commits intomainfrom
add-remove

Conversation

@evans22j
Copy link
Owner

@evans22j evans22j commented Apr 1, 2022

In this milestone:

  • Removed all hardcoded items from the tasks array.
  • Created a new JavaScript file for the new functionality called todolistcrud.js.
  • Implemented a function for adding a new task (add a new element to the array).
  • Implemented a function for deleting a task (remove an element from the array).
  • Implemented a function for editing task descriptions.
  • All changes to the To-Do List are saved in local storage.

Copy link

@elyor-doniyorov elyor-doniyorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evans22j,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️There are no linter errors
✔️The functions for adding, deleting, and editing a task are implemented
✔️Have the property completed set to false and the property index

Required Changes ♻️

  • I think there is an issue when adding and deleting tasks. When I try to delete a task it keeps deleting all tasks, please take a look at the gif below to see and kindly make the necessary changes. 👇
    ezgif com-gif-maker

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@netlify
Copy link

netlify bot commented Apr 2, 2022

Deploy Preview for lambent-hamster-121a58 ready!

Name Link
🔨 Latest commit 2d335f4
🔍 Latest deploy log https://app.netlify.com/sites/lambent-hamster-121a58/deploys/62484b8f918d13000879dfdb
😎 Deploy Preview https://deploy-preview-2--lambent-hamster-121a58.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@BenMukebo BenMukebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approve 🍾 👍 🎊

Hi @evans22j ,

Congratulations! 🎉 Project Approved ✅

Great work on making the changes requested by the previous reviewer 👏🏻
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

To Highlight 🥇

  • Your Pull Request has a proper title and description. ✔️
  • A function for adding a new task has been well implemented.✔️
  • A function for editing task descriptions has been well implemented.✔️
  • A function for deleting a task has been well implemented✔️
  • All changes are saved in local storage, keep rocking 🚀

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏💻

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
    Please, remember to tag me on( @BenMukebo ) in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants