Open
Conversation
|
i try. but it didn't work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced an issue with stacktrace first entry being incorrect.
Say in application we have something like that:
But Sentry received an exception with a bit different trace:
So the first entry in Sentry's trace leads to
pkg/errors, but originally it was referring to the application code.While trying to find the reason behind that I noticed stacktrace conversion in
raven-golooked almost the same as inlogrus_sentryexcept for a- 1part here.To be honest I'm not sure how exactly it works, but I did the same change for
logrus_sentryand now I get correct stacktrace and it seems like all tests here still pass.