Conversation
tested in ec5-stage around Dec 18th 2023
Can handle different ports The handler will actually store the body payload Increased version to 0.7.0 - published
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dummy webserver to better handle malformed headers, improve JSON parsing, and adds Helm chart configuration files for streamlined deployment. Key changes include the introduction of new Helm chart templates and values, modifications to header handling and response generation in the HTTP handler, and updated port configurations.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/dummyserver/templates/ingress.yaml | Adds Ingress resource template for Helm deployment |
| charts/dummyserver/values.yaml | Provides new configuration values for the dummy webserver |
| charts/dummyserver/templates/deployment.yaml | Introduces Deployment template with updated settings |
| charts/dummyserver/Chart.yaml | Defines chart metadata for the dummyserver |
| charts/dummyserver-stage-config/dummyserver-stage-config.yaml | Adds stage configuration overriding default service settings |
| charts/dummyserver/templates/tests/test-connection.yaml | Provides a Helm test for connectivity |
| charts/dummyserver.template.yaml | Generates complete manifest for the release |
| charts/dummyserver/templates/service.yaml | Provides service definition with updated ports |
| dummyserver/handler.py | Updates header handling, JSON parsing, and logging |
| dummyserver/main.py | Updates port configuration and thread daemon settings |
| README.md | Updates documentation regarding response behavior |
Comments suppressed due to low confidence (1)
dummyserver/handler.py:156
- The use of 'UTF' as the encoding is non-standard; consider using 'utf-8' for both encoding and decoding to ensure compatibility.
expected = 'Basic ' + HTTPHandler.credentials.decode('UTF')
| - name: dummyserver | ||
| securityContext: | ||
| {} | ||
| image: "public.ecr.aws/eurotech-dev/dummy-webserver:0.6.0:0.6.0" |
There was a problem hiding this comment.
The image tag appears to be duplicated. Please update it to a single version tag, for example: "public.ecr.aws/eurotech-dev/dummy-webserver:0.6.0".
| image: "public.ecr.aws/eurotech-dev/dummy-webserver:0.6.0:0.6.0" | |
| image: "public.ecr.aws/eurotech-dev/dummy-webserver:0.6.0" |
| self.send_header('Content-type', CONTENT_TYPE) | ||
| self.send_response(response_status_code) | ||
| if send_extra_header: | ||
| self.send_header('WWW-Authenticate', 'Test') |
There was a problem hiding this comment.
The header 'WWW-Authenticate' is sent before calling send_response in the unauthorized branch. This may cause an improper HTTP response; please call send_response before sending any headers.
3 participants
Updating dummy webserver