This repository was archived by the owner on Nov 13, 2017. It is now read-only.
Updated for Swift 2 and enabled size classes#1
Open
masonbedard wants to merge 3 commits intoeugenpirogoff:masterfrom
Open
Updated for Swift 2 and enabled size classes#1masonbedard wants to merge 3 commits intoeugenpirogoff:masterfrom
masonbedard wants to merge 3 commits intoeugenpirogoff:masterfrom
Conversation
added 3 commits
January 18, 2016 13:40
Owner
|
Thank you very much for this PR @masonbedard Sorry for the long review time upfront. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would not build in Swift 2 so fixed print statements and takeUnretainedValue(). I can't tell from the documentation if metadata should be unowned, but when I make it unowned the app crashes.
Camera view was misplaced on iPhone 6s so size classes are now enabled and it should be placed correctly.