Conversation
gzandiemer
requested changes
Oct 11, 2020
| score = 0 | ||
| level = 0 | ||
| lineCounter = 0 | ||
| basePoints = [40, 100, 300, 1200] |
Collaborator
There was a problem hiding this comment.
A very good and clean solution in general but it fails when the player doesn't clear any line and we have "0" in our input array. In the instructions, the input range is given from 0 to 4. You seem to have ignored the "0" part also in your tests. ; ) Can you please edit your function and push it again?
| describe("scores", function () { | ||
| test("should get correct answer", function () { | ||
| expect(get_score([4, 2, 2, 3, 3, 4, 2])).toEqual(4900) | ||
| }) |
Collaborator
There was a problem hiding this comment.
To be secure with your solution try adding several cases in your tests, especially the tricky ones. ; )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.