[work in progress] improve keyboard performance#25
Open
ngokevin wants to merge 7 commits intoetiennepinchon:masterfrom
Open
[work in progress] improve keyboard performance#25ngokevin wants to merge 7 commits intoetiennepinchon:masterfrom
ngokevin wants to merge 7 commits intoetiennepinchon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyboard is 200 draw calls and lots of vertices/faces and raycastable elements.
Improvements:
<a-rounded>, useslice9component instead. The slice9 component is a normal plane, using transparent texture and UVs to get the rounded effect. This cleans up tons of vertices by rounding in material versus geometry.To do: